• jjjalljs@ttrpg.network
    link
    fedilink
    arrow-up
    2
    ·
    7 months ago

    You might end up with a “hostage” situation.

    Reminds me of a guy I used to work with.

    He’d have like a pretty normal PR to do something like change a field to be read only in some API. But then snuck into the pr there’d also be something like “change application to run locally different than prod for entirely selfish reasons” or “lower global coverage requirements” or “disable type checking in this whole folder”

    • magic_lobster_party@kbin.run
      link
      fedilink
      arrow-up
      2
      ·
      7 months ago

      I also worked with a guy like that. Impossible to predict what he was going to do in his next PR. Always a nightmare to review. Also exhausting to argue with, so let some things slide because I was so done dealing with his bs.

      • jjjalljs@ttrpg.network
        link
        fedilink
        arrow-up
        2
        ·
        7 months ago

        This guy was also difficult to argue with. He was always professional, which I guess is worth something.

        One time he tried to remove all the types from a bunch of code “because they were all going to change later.” I refused to allow this. We went back and forth in the comments for hours. I think eventually the lead or boss got involved. Thankfully people sided with me.

        His “later” project that was allegedly going to change all the things was rejected by the team. The code in question is still used and properly typed a year later.